[PATCH v2] xrandr: display gamma and brightness
mhopf at suse.de
Mon Jan 18 09:41:46 PST 2010
On Jan 18, 10 00:17:51 +0100, Éric Piel wrote:
> Even in verbose query mode, gamma and brigthness were not displayed.
> That's because they are not stored in the server the same way they are
> specified on the command line: they are stored as 256 * 3 u16 while
> the command line is 3 + 1 floats. Still, this is useful info for the
> users, and they don't care about how it's stored in the server.
Looks good, except for that with RandR 1.1 drivers (like NVidia) xrandr -q
would fail (output default cannot get gamma size). Both error cases
should print out warnings and continue without printing gamma and
Also, these error messages are pretty bad english (from my non-native
point of view :-] ).
With those two changes:
Reviewed-By: Matthias Hopf <mhopf at suse.de>
Disconnected outputs print out gamma 0.0:0.0:0.0...
Maybe disconnected outputs shouldn't print any gamma?
Matthias Hopf <mhopf at suse.de> __ __ __
Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat at mshopf.de
Phone +49-911-74053-715 __) |_| __) |__ R & D www.mshopf.de
More information about the xorg-devel