[PATCH app-xfs 2/3] doc: remove pdf target for developer's doc

[Gaetan Nadon]

On Wed, 2010-01-20 at 10:36 -0800, Dan Nicholson wrote:

> On Wed, Jan 20, 2010 at 10:01 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
> > It breaks the build under the default configure options
> > Cannot find anyone who can build it.
> > The text and html format should be sufficient.
> >
> > Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> > ---
> >  Makefile.am |    5 +----
> >  1 files changed, 1 insertions(+), 4 deletions(-)
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index fe4639c..6d4d176 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -175,7 +175,7 @@ EXTRA_DIST += doc/xfs-design.xml doc/xfs-design.css doc/xfs-design.xsl
> >
> >  if MAKE_DEVEL_DOCS
> >  if HAVE_XMLTO
> > -noinst_DATA = doc/xfs-design/index.html doc/xfs-design.pdf doc/xfs-design.txt
> > +noinst_DATA = doc/xfs-design/index.html doc/xfs-design.txt
> >  CLEANFILES += $(noinst_DATA)
> >
> >  doc/xfs-design/index.html: $(srcdir)/doc/xfs-design.xml $(srcdir)/doc/xfs-design.xsl doc/xfs-design/xfs-design.css
> > @@ -189,9 +189,6 @@ doc/xfs-design/xfs-design.css: $(srcdir)/doc/xfs-design.css
> >  clean-local:
> >        -rm -rf doc/xfs-design
> >
> > -doc/xfs-design.pdf: $(srcdir)/doc/xfs-design.xml $(srcdir)/doc/xfs-design.xsl
> > -       $(AM_V_GEN)$(XMLTO) -m $(srcdir)/doc/xfs-design.xsl -o doc pdf $(srcdir)/doc/xfs-design.xml
> > -
> >  doc/xfs-design.txt: $(srcdir)/doc/xfs-design.xml $(srcdir)/doc/xfs-design.xsl
> >        $(AM_V_GEN)$(XMLTO) -m $(srcdir)/doc/xfs-design.xsl -o doc txt $(srcdir)/doc/xfs-design.xml
> 
> If you want to remove the pdf from noinst_DATA, that's fine, but don't
> remove the target. Someone can still build the pdf if they want, too.
> Furthermore, pdf is a supported target from xmlto. I've built pdfs
> from docbook many times. You just need to have the necessary backends.
> 

Ok, keep the target. Have you been able to build xfs doc specifically? 
I did check carefully I had all the packages installed.

The folks at Gentoo were not:
http://bugs.gentoo.org/show_bug.cgi?id=274925#c12
It's not in my distro, so I presume Debian were not able either.
A similar target is missing from noinst_DATA in libXfont when it was
first checked-in
I couldn't find any pdf created from xmlto in the whole X.Org build
The problem may be in the source rather than in the tool.

Thanks

> --
> Dan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.x.org/archives/xorg-devel/attachments/20100120/edbab33c/attachment.htm