[PATCH] xfree: dri2: add AuthMagic hook for driver side support
tiago.vignatti at nokia.com
Mon Jan 25 10:11:45 PST 2010
On Sat, Jan 23, 2010 at 09:43:13PM +0100, ext Aaron Plattner wrote:
> On Fri, Jan 22, 2010 at 09:04:26AM -0800, Tiago Vignatti wrote:
> > With this new hook drmAuthMagic becomes useless and should be deprecated.
> > You might want to implement AuthMagic on driver side instead.
> > Attention: ABI being break.
> I'll leave the review to the DRI2 experts, but I think you should either
> keep the server compatible with DRI2INFOREC_VERSION 3 and 4 drivers, or
> remove the compatibility code to deal with the new fields Jesse added being
> missing. Also, I don't think you need to bump DRI2INFOREC_VERSION again
> since Jesse already raised it to 4 and there hasn't been a release since.
> You can't just unconditionally copy AuthMagic out of the structure passed
> in by the driver, because if it's version 3 or 4, that will read past the
> end of what the driver allocated.
I agree with your two points here. Indeed seems we can let version 4 given
Xorg wasn't release with such API's version yet.
> Finally, you'll need to resolve your chanage against my changes in "[PATCH]
> DRI2: Allow multiple driver names."
But wasn't integrate, right? I would if that was the case.
Thanks for reviewing, Aaron.
More information about the xorg-devel