[PATCH] configure: introduce --{enable,disable}-libdrm

[Dan Nicholson]

On Mon, Jan 25, 2010 at 10:15 AM, Tiago Vignatti
<tiago.vignatti at nokia.com> wrote:
> On Fri, Jan 22, 2010 at 11:18:20PM +0100, ext Gaetan Nadon wrote:
>> On Fri, 2010-01-22 at 19:04 +0200, Tiago Vignatti wrote:
>>
>>  if test "x$DRI" = xyes || test "x$DRI2" = xyes; then
>> -       PKG_CHECK_MODULES([LIBDRM], $LIBDRM)
>> -       AC_SUBST(LIBDRM_CFLAGS)
>> -       AC_SUBST(LIBDRM_LIBS)
>> +       if test "x$DRM" = xyes; then
>> +               AC_DEFINE(WITH_LIBDRM, 1, [Building with libdrm support])
>> +               PKG_CHECK_MODULES([LIBDRM], $LIBDRM)
>> +               AC_SUBST(LIBDRM_CFLAGS)
>> +               AC_SUBST(LIBDRM_LIBS)
>>
>>
>>                     nit:        AC_SUBST not required, already done by PKG_CHECK_MODULES
>>
>
> Are you sure about it? If so, we need to patch all configure.ac doing such
> correction.

That's correct. The first argument to PKG_CHECK_MODULES will have
_CFLAGS and _LIBS appended and AC_SUBST'd with the appropriate values.
So, the AC_SUBST is redundant. It doesn't hurt, though.

--
Dan