[PATCH 06/11] xkb: purge _XkbLibError.
daniel at fooishbar.org
Mon Jan 25 21:33:27 PST 2010
On Mon, Jan 25, 2010 at 05:51:07AM -0800, Dan Nicholson wrote:
> On Sun, Jan 24, 2010 at 12:31 PM, Keith Packard <keithp at keithp.com> wrote:
> > On Mon, 18 Jan 2010 16:35:56 +1300, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> >> The only thing I'm sort-of worried about is that it does serve as some
> >> easily human-readble documentation about the errors that may happen. I'm
> >> happy enough to give this one a respin with DebugF instead.
> > I haven't seen an updated version of this with a Reviewed-by: line yet.
> It's debatable whether holding this up on converting the
> errors/warnings to DebugF is worth it. I don't know what Peter's
> thoughts are.
While I'm all for making it easier to debug XKB, most of those should
be superfluous: for the XKM stuff, we'll only fail if xkbcomp is broken
or if the client hands us invalid XKM, and for most of the rest of it,
it looks like we'd be crashing in other code long before we ever reached
those error messages.
So, with or without the DebugF conversion, for the series:
Reviewed-by: Daniel Stone <daniel at fooishbar.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20100126/3bc61ce8/attachment-0001.pgp
More information about the xorg-devel