[PATCH 1/2] OS support: fix writeable client vs IgnoreClient behavior

Jesse Barnes jbarnes at virtuousgeek.org
Wed Jul 7 16:03:18 PDT 2010


On Wed, 7 Jul 2010 15:54:50 -0700
Aaron Plattner <aplattner at nvidia.com> wrote:

> On Fri, Jul 02, 2010 at 09:33:54AM -0700, Jesse Barnes wrote:
> > On Fri, 2 Jul 2010 10:45:52 +1000
> > Peter Hutterer <peter.hutterer at who-t.net> wrote:
> > 
> > > On Wed, Jun 30, 2010 at 10:55:52AM -0700, Jesse Barnes wrote:
> > > > > > This looks good to me. I assume the client is allocated with calloc so
> > > > > > that the count starts out at zero?
> > > > > > 
> > > > > > Reviewed-by: Keith Packard <keithp at keithp.com>
> > > > > 
> > > > > With the memset in InitClient noted:
> > > > > Reviewed-by: Daniel Stone <daniel at fooishbar.org>
> > > > 
> > > > Peter, can you cherry pick this over to the 1.8 branch as well?
> > > 
> > > sorry, that came in too late, after I had already tagged and started
> > > build-testing 1.8.2. Please feel free to push it to server-1.8-branch
> > > yourself, the branch is open now.
> > 
> > Ok just pushed it, thanks.
> 
> Sorry, I was behind on email again.  This is an ABI break due to the
> addition of 'ignoreCount' in the middle of ClientRec, and is therefore not
> appropriate for server-1.8-branch.

Arg yeah.  Can we move it to the end or do we have to revert?

-- 
Jesse Barnes, Intel Open Source Technology Center


More information about the xorg-devel mailing list