[PATCH libX11 2/4] XStringToKeysym: Special case for XF86 keysyms

Keith Packard keithp at keithp.com
Thu Jul 8 08:45:45 PDT 2010


On Thu,  8 Jul 2010 15:00:33 +0100, Daniel Stone <daniel at fooishbar.org> wrote:

> +    if (strncmp(s, "XF86_", 5) == 0) {
> +        KeySym ret;
> +        char *tmp = strdup(s);

Please check malloc returns in Xlib...

Otherwise,

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100708/df884ef2/attachment.pgp>


More information about the xorg-devel mailing list