xwininfo: Changes to 'master'

Jeremy Huddleston jeremyhu at apple.com
Sat Jul 10 09:31:19 PDT 2010


This introduces a build failure on darwin.  You need to provide strnlen (look at xlsclients)

On Jul 7, 2010, at 10:48, Alan Coopersmith wrote:

> COPYING      |    2 
> clientwin.c  |  178 +++---
> clientwin.h  |    6 
> configure.ac |   29 -
> dsimple.c    |  678 +++++++++++++++++-------
> dsimple.h    |   56 --
> xwininfo.c   | 1633 ++++++++++++++++++++++++++++++++++++++++++++---------------
> 7 files changed, 1887 insertions(+), 695 deletions(-)
> 
> New commits:
> commit 3fa31068bcae6a5bee7fbd41788e13d6d56da8c0
> Author: Alan Coopersmith <alan.coopersmith at oracle.com>
> Date:   Wed Jun 30 18:38:57 2010 -0700
> 
>    Make iconv() usage optional
> 
>    Allows building without iconv, though character set conversion will not
>    be supported in that case.
> 
>    Handles UTF8_STRING validation and output for UTF-8 locales without iconv
>    (using is_valid_utf8() function copied from X.Org's app/xprop/xprop.c)
> 
>    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>    Reviewed-by: James Cloos <cloos at jhcloos.com>
> 
> commit 6a4f77d4ac1737dd49f3462d98e0f7e41e50ab18
> Author: Alan Coopersmith <alan.coopersmith at oracle.com>
> Date:   Tue Jun 29 22:51:38 2010 -0700
> 
>    Add some EWMH hints to the -wm output
> 
>    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>    Reviewed-by: James Cloos <cloos at jhcloos.com>
> 
> commit baf759d33b4b360fef2b2c61094ef109bec708fa
> Author: Alan Coopersmith <alan.coopersmith at oracle.com>
> Date:   Tue Jun 29 17:56:07 2010 -0700
> 
>    Handle non-latin-1 window names
> 
>    Uses _NET_WM_NAME to get UTF-8 encoding, iconv to convert to current locale
>    Warns that COMPOUND_TEXT WM_NAMEs aren't supported if _NET_WM_NAME isn't set
>    Adds local atom caching code to dsimple.c and uses it in all three *.c
> 
>    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>    Reviewed-by: James Cloos <cloos at jhcloos.com>
> 
> commit 6ec3573d7876fa62d2a81057ce0d16ed328fad1f
> Author: Alan Coopersmith <alan.coopersmith at oracle.com>
> Date:   Fri Jun 25 21:41:21 2010 -0700
> 
>    Make xcb-icccm dependency be optional and off-by-default
> 
>    Changes to the xcb-icccm API/ABI are under discussion, so for now default
>    to using local property handling code modeled after the current API, with
>    a --with-xcb-icccm to enable use of the API for testing/development.
> 
>    Once the API/ABI is stable & released, this set of changes should be
>    removed and the xcb-icccm API just used directly.
> 
>    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>    Reviewed-by: James Cloos <cloos at jhcloos.com>
> 
> commit 96f19bade9ce4940642d580f4c52e2bc0e3539ab
> Author: Alan Coopersmith <alan.coopersmith at oracle.com>
> Date:   Sun Jun 13 12:42:34 2010 -0700
> 
>    Convert from Xlib to xcb
> 
>    Testing was done with a simple GNOME 2.28 session with a number of
>    applications open (gnome-terminal, VirtualBox, Firefox).
> 
>    Primary test case was xwininfo -root -all, which listed 114 children of
>    the root window.   Output was identical to Xlib version (after applying
>    the fix to libxcb_icccm for always null-terminating wm_class properties).
> 
>    Over a local connection on the same machine:
> 
>    Xlib:	0.00u 0.01s 0:00.05 20.0%
>    xcb:	0.00u 0.00s 0:00.02 0.0%
> 
>    (i.e. barely measurable difference - I had more variation between
>     repeated runs of the command)
> 
>    Introducing latency by running over ssh -X from California to Beijing
>    and back:
> 
>    Xlib:	0.03u 0.02s 8:19.12 0.0%
>    xcb:	0.00u 0.00s 0:45.26 0.0%
> 
>    Memory size when exit() is called:
> 
>    Xlib:
>     Address  Kbytes     RSS    Anon  Locked Mode   Mapped File
>    08043000      20      20      20       - rw---    [ stack ]
>    08400000     144     144     144       - rw---    [ heap ]
>    total Kb    8972    8640     316       -
> 
>    xcb:
>     Address  Kbytes     RSS    Anon  Locked Mode   Mapped File
>    08045000      12      12      12       - rwx--    [ stack ]
>    0806C000     100     100     100       - rwx--    [ heap ]
>    total Kb    7980    7692     288       -
> 
>    Bytes sent & received (counted by proxying via xscope):
> 
>    Xlib: Client --> Server: 21380 bytes   Client <-- Server:  54124 bytes
>    xcb:  Client --> Server: 21114 bytes   Client <-- Server:  53160 bytes
> 
>    (The Xlib code didn't save any replies, so re-requested a couple of things
>     when running with -all - I fixed that while porting to xcb, but the same
>     could be done with Xlib easily too.)
> 
>    Not yet handled: WM_NAME properties that need to be converted from another
>    character encoding.
> 
>    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>    Reviewed-by: James Cloos <cloos at jhcloos.com>
> 
> _______________________________________________
> xorg-commit mailing list
> xorg-commit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xorg-commit



More information about the xorg-devel mailing list