xkbcomp: Changes to 'master'

Julien Cristau jcristau at debian.org
Mon Jul 12 03:26:45 PDT 2010


On Mon, Jul 12, 2010 at 11:16:28 +0100, Julien Cristau wrote:

> The patch I tested didn't change unscanchar(), and I'm not sure changing
> it will work correctly.  On end of file, scanchar() will set
> readBuf[readBufPos] to (char)EOF.  Then unscanchar(EOF) will compare EOF
> with (char)EOF, which will fail if char is unsigned.
> 
Scratch that, it seems to work anyway.  I still feel it shouldn't be
necessary to reimplement getc though.

Cheers,
Julien


More information about the xorg-devel mailing list