[PATCH] loader: when creating sdksyms.c only include shmint.h if MITSHM is enabled. #29109

Tiago Vignatti tiago.vignatti at nokia.com
Fri Jul 16 08:10:11 PDT 2010


On Fri, Jul 16, 2010 at 03:47:35PM +0200, ext Michael Olbrich wrote:
> When configured with --disable-mitshm the symbols declared in shmint.h
> do not exist. By guarding the include with '#ifdef MITSHM' these
> symbols are skipped when generating sdksyms.c with --disable-mitshm.
> 
> Signed-off-by: Michael Olbrich <m.olbrich at pengutronix.de>

Reviewed-by: Tiago Vignatti <tiago.vignatti at nokia.com>


Seems we're mixing the MITSHM and HAS_SHM defines a bit also. Perhaps just set
an option to disable all shm access is enough for us? Note that currently
--disable-shm is a misname; should be --disable-mitshm, or --disable-xmitshm
or something like that (concerning the extension only).


Thanks,
             Tiago


More information about the xorg-devel mailing list