[PATCH video-ati] The local copy of the modes code is no longer required.
Alex Deucher
alexdeucher at gmail.com
Tue Jul 20 22:00:20 PDT 2010
On Mon, Jul 19, 2010 at 5:25 PM, Gaetan Nadon <memsize at videotron.ca> wrote:
> The server 1.2 as shipped in the tarball on the web does not contain the
> modes code. It was added just after and found in git branch server-1.2-branch.
>
> The modes code was initially included in version ati 6.8.0 and fails to compile
> with server 1.2 as it requires randr 1.2. The modes code is included in server
> versions 1.3 and later, so there is no need to provide an unknown version of
> the modes code in the ati driver tarball. It will never be used.
>
> This patch makes the ati driver requiring server 1.3 or later.
> Version 6.8.0 configures and builds ok on server 1.3
> Master branch post 6.13.1 configures and builds ok on server 1.3
I haven't had time to test this old stuff in ages, so unless there is
anyone that still uses or needs the old compat code, I'm fine with
this patch. Any distros out there still use this?
Alex
>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
> configure.ac | 54 +-----------------------------------------------
> src/Makefile.am | 24 ---------------------
> src/local_xf86Rename.h | 23 --------------------
> 3 files changed, 1 insertions(+), 100 deletions(-)
> delete mode 100644 src/local_xf86Rename.h
>
> diff --git a/configure.ac b/configure.ac
> index cf0a855..cbc1fe6 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -76,11 +76,6 @@ AC_ARG_ENABLE(kms,
> [DRM_MODE="$enableval"],
> [DRM_MODE=yes])
>
> -AC_ARG_WITH(xserver-source,AC_HELP_STRING([--with-xserver-source=XSERVER_SOURCE],
> - [Path to X server source tree]),
> - [ XSERVER_SOURCE="$withval" ],
> - [ XSERVER_SOURCE="" ])
> -
> # Checks for extensions
> XORG_DRIVER_CHECK_EXT(RANDR, randrproto)
> XORG_DRIVER_CHECK_EXT(RENDER, renderproto)
> @@ -88,7 +83,7 @@ XORG_DRIVER_CHECK_EXT(XV, videoproto)
> XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto)
>
> # Checks for pkg-config packages
> -PKG_CHECK_MODULES(XORG, [xorg-server >= 1.2 xproto fontsproto $REQUIRED_MODULES])
> +PKG_CHECK_MODULES(XORG, [xorg-server >= 1.3 xproto fontsproto $REQUIRED_MODULES])
> PKG_CHECK_MODULES(XEXT, [xextproto >= 7.0.99.1],
> HAVE_XEXTPROTO_71="yes"; AC_DEFINE(HAVE_XEXTPROTO_71, 1, [xextproto 7.1 available]),
> HAVE_XEXTPROTO_71="no")
> @@ -165,11 +160,6 @@ fi
> AM_CONDITIONAL(DRM_MODE, test x$DRM_MODE = xyes)
> AM_CONDITIONAL(LIBUDEV, test x$LIBUDEV = xyes)
>
> -save_CFLAGS="$CFLAGS"
> -CFLAGS="$XORG_CFLAGS"
> -AC_CHECK_HEADER(xf86Modes.h,[XMODES=yes],[XMODES=no],[#include "xorg-server.h"])
> -CFLAGS="$save_CFLAGS"
> -
> AC_DEFINE(USE_XAA, 1, [Build support for XAA])
>
> # Properly handle EXA.
> @@ -240,48 +230,6 @@ AC_CHECK_DECL(XSERVER_LIBPCIACCESS,
> [XSERVER_LIBPCIACCESS=yes],[XSERVER_LIBPCIACCESS=no],
> [#include "xorg-server.h"])
>
> -AM_CONDITIONAL(XMODES, test "x$XMODES" = xno)
> -
> -if test "x$XSERVER_SOURCE" = x; then
> - if test -d ../../xserver; then
> - XSERVER_SOURCE="`cd ../../xserver && pwd`"
> - fi
> -fi
> -
> -if test -d "$XSERVER_SOURCE"; then
> - case "$XSERVER_SOURCE" in
> - /*)
> - ;;
> - *)
> - XSERVER_SOURCE="`cd $XSERVER_SOURCE && pwd`"
> - esac
> - if test -f src/modes/xf86Modes.h; then
> - :
> - else
> - ln -sf $XSERVER_SOURCE/hw/xfree86/modes src/modes
> - fi
> -
> - if test -f src/parser/xf86Parser.h; then
> - :
> - else
> - ln -sf $XSERVER_SOURCE/hw/xfree86/parser src/parser
> - fi
> -fi
> -if test "x$XMODES" = xyes; then
> - AC_MSG_NOTICE([X server has new mode code])
> - AC_DEFINE(XMODES, 1,[X server has built-in mode code])
> - XMODES_CFLAGS=
> -else
> - if test -f src/modes/xf86Modes.h -a -f src/parser/xf86Parser.h; then
> - AC_MSG_NOTICE([X server is missing new mode code, using local copy])
> - else
> - AC_MSG_ERROR([Must have X server >= 1.3 source tree for mode setting code. Please specify --with-xserver-source])
> - fi
> - XMODES_CFLAGS='-DXF86_MODES_RENAME -I$(top_srcdir)/src -I$(top_srcdir)/src/modes -I$(top_srcdir)/src/parser'
> -fi
> -
> -AC_SUBST([XMODES_CFLAGS])
> -
> CPPFLAGS="$SAVE_CPPFLAGS"
>
> AM_CONDITIONAL(USE_EXA, test "x$USE_EXA" = xyes)
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 0ce46b0..5750770 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -48,23 +48,6 @@ RADEON_ATOMBIOS_SOURCES = \
> AtomBios/includes/ObjectID.h \
> AtomBios/includes/regsdef.h
>
> -XMODE_SRCS=\
> - local_xf86Rename.h \
> - parser/xf86Parser.h \
> - parser/xf86Optrec.h \
> - modes/xf86Modes.h \
> - modes/xf86Modes.c \
> - modes/xf86cvt.c \
> - modes/xf86Crtc.h \
> - modes/xf86Crtc.c \
> - modes/xf86Cursors.c \
> - modes/xf86EdidModes.c \
> - modes/xf86RandR12.c \
> - modes/xf86RandR12.h \
> - modes/xf86Rename.h \
> - modes/xf86Rotate.c \
> - modes/xf86DiDGA.c
> -
> if XF86DRM_MODE
> RADEON_KMS_SRCS=radeon_dri2.c radeon_kms.c drmmode_display.c radeon_vbo.c
> endif
> @@ -77,7 +60,6 @@ AM_CFLAGS = \
> @LIBDRM_RADEON_CFLAGS@ \
> @XORG_CFLAGS@ \
> @DRI_CFLAGS@ \
> - @XMODES_CFLAGS@ \
> @LIBUDEV_CFLAGS@ \
> -DDISABLE_EASF \
> -DENABLE_ALL_SERVICE_FUNCTIONS \
> @@ -116,11 +98,6 @@ radeon_drv_la_SOURCES = \
> $(RADEON_DRI_SRCS) $(RADEON_EXA_SOURCES) atombios_output.c atombios_crtc.c \
> $(RADEON_KMS_SRCS)
>
> -if XMODES
> -radeon_drv_la_SOURCES += \
> - $(XMODE_SRCS)
> -endif
> -
> theatre_detect_drv_la_LTLIBRARIES = theatre_detect_drv.la
> theatre_detect_drv_la_LDFLAGS = -module -avoid-version
> theatre_detect_drv_ladir = @moduledir@/multimedia
> @@ -143,7 +120,6 @@ theatre200_drv_la_SOURCES = \
> theatre200.c theatre200_module.c
>
> EXTRA_DIST = \
> - $(XMODE_SRCS) \
> radeon_render.c \
> radeon_accelfuncs.c \
> radeon_textured_videofuncs.c \
> diff --git a/src/local_xf86Rename.h b/src/local_xf86Rename.h
> deleted file mode 100644
> index 5102170..0000000
> --- a/src/local_xf86Rename.h
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -/*
> - * Copyright © 2006 Keith Packard
> - *
> - * Permission to use, copy, modify, distribute, and sell this software and its
> - * documentation for any purpose is hereby granted without fee, provided that
> - * the above copyright notice appear in all copies and that both that copyright
> - * notice and this permission notice appear in supporting documentation, and
> - * that the name of the copyright holders not be used in advertising or
> - * publicity pertaining to distribution of the software without specific,
> - * written prior permission. The copyright holders make no representations
> - * about the suitability of this software for any purpose. It is provided "as
> - * is" without express or implied warranty.
> - *
> - * THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
> - * INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO
> - * EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY SPECIAL, INDIRECT OR
> - * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE,
> - * DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER
> - * TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE
> - * OF THIS SOFTWARE.
> - */
> -
> -#define XF86NAME(x) radeon_##x
> --
> 1.6.0.4
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>
More information about the xorg-devel
mailing list