[PATCH 12/14] xfree86: IOADDRESS is PCIism and shouldn't be used by common header files

Vignatti Tiago (Nokia-D/Helsinki) tiago.vignatti at nokia.com
Tue Jun 1 11:37:27 PDT 2010

On Tue, Jun 01, 2010 at 05:50:17PM +0200, ext Mark Kettenis wrote:
> > From: Tiago Vignatti <tiago.vignatti at nokia.com>
> > Date: Tue,  1 Jun 2010 17:59:08 +0300
> This change does not make it easier to understand the code.  Imagine
> someone looking at it after you apply this diff.  What is the meaning
> of 'vertsyncreg'?  
> Really, if the type is a PCIism, so are the variables that are
> declared using that type.  That may be undesirable, but at least the
> use of IOADDRESS as a type makes that clear.

If I move the IOADDRESS definition to xf86str.h will help then?


More information about the xorg-devel mailing list