[PATCH 06/14] xfree86: bus: move macros from common PCI header to private file

Julien Cristau jcristau at debian.org
Wed Jun 2 05:10:03 PDT 2010

On Tue, Jun  1, 2010 at 21:34:22 +0300, Vignatti Tiago (Nokia-D/Helsinki) wrote:

> Hi,
> On Tue, Jun 01, 2010 at 05:43:10PM +0200, ext Mark Kettenis wrote:
> > 
> > I really, really don't see the point if this diff, and a lot of others
> > you're sending.  Yes, this is only used in the int10 module at this
> > moment.  But obviously Pci.h is the right place for these macros.  It
> > seems to me that you're just randomly shifting code around.  I don't
> > get the big picture, and your terse explanations don't give me any
> > insight.  So all I'm left with is the fear that this will break the
> > platform and/or drivers I care about.
> If you pay attention in the X server code base, it still contains very old and
> complex PCI handling code that does things that only the kernel should do:
> moreover has some left over of ISA code, has int10's ugly and mostly not
> functional, the 16-bit x86 emulator enormous code, remnants from the dead
> Resource Access mechanism, it's mixed with the pciaccess library and so on.
> You will see that all PCI code is a recipe for disaster!
Not wanting to explain the logic behind your changes (no, the above
isn't an explanation), when they're potentially breaking existing code,
doesn't strike me as the best way forward.


More information about the xorg-devel mailing list