[PATCH] composite: set oldpixmap to NULL if we fail to realloc the pixmap.

Dave Airlie airlied at gmail.com
Wed Jun 2 19:21:24 PDT 2010


On Thu, Jun 3, 2010 at 12:09 PM, Keith Packard <keithp at keithp.com> wrote:
> On Thu,  3 Jun 2010 10:16:19 +1000, Dave Airlie <airlied at gmail.com> wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> We don't explicity set the old pixmap to NULL if we fail the realloc, which
>> later leads to us dereferencing an uninitialised or stale pointer.
>
> pOldPixmap *should* already be set to null -- any idea which code path
> that's not getting set in?

hmm malloc + never initialised, new patch sent.

Dave.


More information about the xorg-devel mailing list