[PATCH] dix/window: catch illegal window reconfiguration for composited windows. (v2)

Keith Packard keithp at keithp.com
Wed Jun 2 21:18:09 PDT 2010

On Thu,  3 Jun 2010 09:45:31 +1000, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
> If a windows has been redirected, then it has to respect pixmap size limits,
> 32kx32k. This checks before resizing or changing border width if the window
> is redirected and the pixmap size limits are being hit, and returns
> BadValue.

I don't think this is a reasonable plan; you're only catching really
obvious mistakes and leaving any actual allocation failures unreported
to the client. Given your patch which keeps the server from crashing on
CreatePixmap failure, I'd say this patch isn't all that useful.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100602/f653d8eb/attachment.pgp>

More information about the xorg-devel mailing list