[PATCH] dix/window: catch illegal window reconfiguration for composited windows. (v2)

Dave Airlie airlied at gmail.com
Wed Jun 2 22:02:32 PDT 2010

On Thu, Jun 3, 2010 at 2:44 PM, Dave Airlie <airlied at gmail.com> wrote:
> On Thu, Jun 3, 2010 at 2:18 PM, Keith Packard <keithp at keithp.com> wrote:
>> On Thu,  3 Jun 2010 09:45:31 +1000, Dave Airlie <airlied at gmail.com> wrote:
>>> From: Dave Airlie <airlied at redhat.com>
>>> If a windows has been redirected, then it has to respect pixmap size limits,
>>> 32kx32k. This checks before resizing or changing border width if the window
>>> is redirected and the pixmap size limits are being hit, and returns
>>> BadValue.
>> I don't think this is a reasonable plan; you're only catching really
>> obvious mistakes and leaving any actual allocation failures unreported
>> to the client. Given your patch which keeps the server from crashing on
>> CreatePixmap failure, I'd say this patch isn't all that useful.
> I think its the only possible fix without breaking ABI, which is a
> concern for anyone shipping this in a server that is released, which
> is everyone who probably cares.

Okay I can probably fix it without breaking ABI my moving the
composite reallocation stuff into dix/window.c for redirected windows
and failing early.


More information about the xorg-devel mailing list