[PATCH resent 0/5] xfree86: vgaarb: clean up and device hidden

Vignatti Tiago (Nokia-D/Helsinki) tiago.vignatti at nokia.com
Thu Jun 3 02:41:00 PDT 2010


On Thu, Jun 03, 2010 at 11:29:46AM +0200, ext Mark Kettenis wrote:
> > From: Tiago Vignatti <tiago.vignatti at nokia.com>
> Is it just me or are others also utterly confused by Tiago's diffs?
> Let me explain what I mean:
> > Tiago Vignatti (5):
> >   xfree86: vgaarb: change macros by inline functions to ease debug
> This diff makes VGAGet_GC and VGAPut_GC inline functions...
> >   xfree86: vgaarb: remove superfluous and confusing VGAGet_GC and VGAPut_GC
> ...and then this diff removes them again.
> It's this sort of thing that keeps confusing me (the fact that the
> diffs end up arriving out of order in my mailbox doesn't make it
> easier either).
> If it is just me, I'll just keep my mouth shut after this.  But
> otherwise I'd like to ask Tiago to spend a little bit more effort not
> to create patch series that touch the same bit of code multiple times.

My main concern when creating a series is to keep each commit able to compile
after it's introduced. This ease future bisects when searching for problems.

And what happened in the commits you pointed above was that exactly. I was
just trying to make sure every patch is compilable and the drawbacks are a bit
of confusing like there.

Anyway, thanks for pointing out.


More information about the xorg-devel mailing list