[PATCH] composite: use config notify hook to do pixmap resize.

Keith Packard keithp at keithp.com
Thu Jun 3 07:36:44 PDT 2010

On Thu,  3 Jun 2010 19:06:35 +1000, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
> Since reallocating the backing pixmap can fail, we need to try and do it before any other side effects of reconfiguring the window happen.
> This changes the ConfigNotify hook to return a Bool, and moves the
> composite window reconfiguration wrappers to ConfigNotify. They all
> basically did the same thing, so we can drop the MoveWindow,
> ResizeWindow, ChangeBorderWidth wrappers, and allow ConfigNotify to do
> all the work. If reallocation fails we fail before we send any
> confiureNotify events, or enter the area we can't recover from.

I like this change, but I think ConfigNotify should return a Status
instead of a Bool.

For older servers, I'd suggest just placing a call to composite inside
ConfigureWindow, calling a function that checks to see if the extension was
enabled and then calls compConfigNotify.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100603/f62a6322/attachment.pgp>

More information about the xorg-devel mailing list