[PATCH evdev] Prefix all log messages with "evdev:".
peter.hutterer at who-t.net
Thu Jun 3 19:13:33 PDT 2010
On Thu, Jun 03, 2010 at 07:05:06PM -0700, Alan Coopersmith wrote:
> Peter Hutterer wrote:
> > This way it's more obvious which messages are driver messages and which ones
> > aren't, especially when multiple drivers are fighting over the same device.
> > Also, grep works much better.
> > xf86DrvMsgVerb() cannot be used here, it uses the output driver as prefix.
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> > ---
> > There's the option of having another macro for logging but I'd rather have
> > the code clean, using the server API directly instead of wrapping around it.
> > fwiw, I'm planning to do the same to the other drivers too.
> I was going to ask if we didn't already have xf86DrvMsg, but then realized
> that's only for video drivers since you specify the screen id to identify
> the driver - I wonder if adding a input driver equivalent to the API would
> make sense.
yeah, probably and that might on second though actually be quite useful.
we can pass the InputDriverPtr down which gives us both the device name and
the driver name, so we can enforce that in all drivers much easier too.
More information about the xorg-devel