[PATCH] xkb: fix invalid memory writes in _XkbCopyGeom.

Mikhail Gusarov dottedmag at dottedmag.net
Fri Jun 4 00:15:39 PDT 2010

Twas brillig at 15:41:36 04.06.2010 UTC+10 when peter.hutterer at who-t.net did gyre and gimble:

 PH> for extra fun - this bug is present in pretty all server versions since 1.2
 PH> but didn't get exposed until the xalloc → malloc changes. I just took the
 PH> 1.7 sources and valgrind didn't complain. Changed xalloc to malloc, valgrind
 PH> gives out.

 PH> Any guesses to why xalloc hides this issue are appreciated.

Due to additional 4 bytes alignment in Xalloc, so it worked 75% of the
time :) Hence xalloc->malloc made this bug explicit. I will have a look.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100604/6cb10a82/attachment.pgp>

More information about the xorg-devel mailing list