[PATCH luit] Integrate changes from Thomas Dickey's luit-20100601 fork

Alan Coopersmith alan.coopersmith at oracle.com
Sun Jun 6 11:11:29 PDT 2010

Jeremy Huddleston wrote:
> Patch is attached since it is rather sizable.
> I basically just copied Thomas' changes with minor edits of my own:
> Got rid of RCS tags
> guarded #include "config.h"
> It passes my  "hey, look... it runs" test, but I haven't audited the changes yet.

A lot of the changes are whitespace (most of which are improvements) - applying
the patch to my clone and running git diff -w b --color-words made a much
shorter set of changes to review, though git am did give two warnings about
adding spaces to the end of lines in the configure.ac additions:

.dotest/patch:1053: trailing whitespace.
.dotest/patch:1067: trailing whitespace.
                AC_CHECK_HEADERS( \

(A space after a line continuation \ either breaks it, or shows it's not really

I note a lot of "NULL" changing back to "0" - sparse likes to complain
about it, but it's mostly a style thing.   (On Solaris, NULL is defined
as just 0, though I know some other platforms define it as (void *) 0.)

A couple other changes from our fork that I note got lost in the merge:

 - declaring global variables static if they're only used in one file
	(from pcpa in commit 638f4ac8)

 - Juliusz's email address changed in the man page

The rest seems fine.   (I can't claim to fully understand the terminal
handling intricacies, but I see nothing to object to in them.)

	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list