[PATCH] xorg: Add nr for background=none root

Keith Packard keithp at keithp.com
Sun Jun 6 22:01:55 PDT 2010

On Mon,  7 Jun 2010 14:08:37 +1000, Dave Airlie <airlied at gmail.com> wrote:
> From: Adam Jackson <ajax at redhat.com>
> (I'm blaming ajax for this, but it could have be krh, either way its came from Red Hat, so I can sign it off.)
> This adds support to the X server so that the driver can let the
> server know if it needs to draw a background when the -nr option is
> passed. If the driver can copy the framebuffer cleanly it sets the
> flag, it if can't the server will fallback to normal behaviour.

What will this do on non-xf86 servers? Is there some more explicit way
we could ask whether bgNoneRoot was OK and set that here instead of
hoping that the driver dtrt? Perhaps some simple mechanism like:

       pWin->backgroundState = BackgroundPixel;

       if (pWin->backgroundState == BackgroundNone && bgNoneRoot)

That way the driver could signal that BackgroundNone was OK by simply
always setting it, and DIX could check that.

That seems less magic than the current patch, although still sub-optimal.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100606/d28f2165/attachment.pgp>

More information about the xorg-devel mailing list