[PATCH] DRI2: Don't return junk reply instead of blocking in glXWaitForSbcOML()

Jesse Barnes jbarnes at virtuousgeek.org
Wed Jun 9 12:35:02 PDT 2010

On Sat,  5 Jun 2010 13:09:28 +0200
Mario Kleiner <mario.kleiner at tuebingen.mpg.de> wrote:

> DRI2WaitSBC() didn't block if requested targetSBC wasn't yet reached.
> Instead it returned a xreply with uninitialized junk return values, then
> blocked the connection until targetSBC was reached.
> Therefore the client didn't block, but continued with bogus return
> values from glXWaitForSbcOML.
> This patch fixes the problem by implementing DRI2WaitSBC similar
> to the clean and proven DRI2WaitMSC implementation.
> Signed-off-by: Mario Kleiner <mario.kleiner at tuebingen.mpg.de>

Looks good, thanks.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Keith and Peter, can you guys pick this up into master and the stable

Jesse Barnes, Intel Open Source Technology Center

More information about the xorg-devel mailing list