[PATCH] Ignore RandR timestamps harder

Chase Douglas chase.douglas at canonical.com
Thu Jun 10 10:49:52 PDT 2010


On Thu, 2010-06-10 at 07:38 -0700, Keith Packard wrote:
> Checking timestamps in post 1.1 randr requests was never a good idea,
> let's ignore them and just make the configuration changes.
> 
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
> 
> Because the new randr code uses persistent resource ids for all of the
> objects in question, there's no concern that the configuration will do
> something weird if done with stale information. As such, we really don't
> need to check these timestamps, they serve only to cause random failures
> when applications get them wrong somehow.
> 
>  randr/rrcrtc.c |   33 ---------------------------------
>  1 files changed, 0 insertions(+), 33 deletions(-)

I believe this is what I was working around with the following patch:

http://git.gnome.org/browse/gnome-settings-daemon/commit/?id=c114f0ca3da756725996bfa2111b2cc4e1982d92

I didn't know the rationale for checking timestamps, so I didn't propose
fixing the issue in X. However, dropping the check seems right in my
mind.

Acked-by: Chase Douglas <chase.douglas at canonical.com>



More information about the xorg-devel mailing list