[PATCH input-keyboard 4/4] config: restore inputdir automake variable

Gaetan Nadon memsize at videotron.ca
Fri Jun 11 11:58:17 PDT 2010

On Fri, 2010-06-11 at 20:31 +0200, Julien Cristau wrote:

> On Fri, Jun 11, 2010 at 14:06:41 -0400, Gaetan Nadon wrote:
> > All input drivers use this variable to set the installation
> > path of the input module. For this driver, it was changed
> > in commit 708ecbf8557d9e676e3bb07c1f83170f6d9f7cd7.
> > One way or another is fine, but breaking a pattern is error prone.
> Hrm.  OK, i guess.
> > Also restore the use of DRIVER_NAME variable.
> > 
> This i don't really see the point.  It makes it look like it's possible
> to trivially rename the driver, which is not true.

The objective is to restore the pattern used by all input and video
drivers. I agree it's not a big deal for DRIVER_NAME. I am open to
suggestions to re-write this piece if something better is found. It's
easier and less error prone if the same configuration is done the same

Just thinking about pros and cons now, using the DRIVER_NAME variable
probably prevents hard to find typos in the driver name when it is being
repeated many times. Just like we do in C with #define.

There was no comment as to why it was changed, I thought perhaps I
missed something.

        xf86-input-acecad/src/Makefile.am:@DRIVER_NAME at _drv_ladir = @inputdir@
        xf86-input-aiptek/src/Makefile.am:@DRIVER_NAME at _drv_ladir = @inputdir@
        xf86-input-evdev/src/Makefile.am:@DRIVER_NAME at _drv_ladir = @inputdir@
        xf86-input-joystick/src/Makefile.am:@DRIVER_NAME at _drv_ladir = @inputdir@
        xf86-input-keyboard/src/Makefile.am:@DRIVER_NAME at _drv_ladir = @inputdir@	<-----
        xf86-input-mouse/src/Makefile.am:@DRIVER_NAME at _drv_ladir = @inputdir@
        xf86-input-penmount/src/Makefile.am:@DRIVER_NAME at _drv_ladir = @inputdir@
        xf86-input-synaptics/src/Makefile.am:@DRIVER_NAME at _drv_ladir = @inputdir@
        xf86-input-vmmouse/src/Makefile.am:@DRIVER_NAME at _drv_ladir = @inputdir@
        xf86-input-void/src/Makefile.am:@DRIVER_NAME at _drv_ladir = @inputdir@
        xf86-input-wacom/src/Makefile.am:@DRIVER_NAME at _drv_ladir = @inputdir@

    + all the video drivers

BTW, I posted v2 for xorg-server.pc


> Cheers,
> Julien
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100611/a31e85f4/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100611/a31e85f4/attachment.pgp>

More information about the xorg-devel mailing list