[PATCH 1/5] mi: Remove unused overlay support
dottedmag at dottedmag.net
Fri Jun 11 12:02:54 PDT 2010
Twas brillig at 11:29:26 11.06.2010 UTC-07 when jamey at minilop.net did gyre and gimble:
JS> It wasn't obvious to me that the patch was correct, because you
JS> pretend that miOverlayCopyUnderlay returns false instead of
JS> crashing. But on further inspection I see that XAACopyWindow8_32
JS> could only set doUnderlay to true if it's called from
JS> miOverlayMoveWindow or miOverlayResizeWindow, which can only be
JS> called if miInitOverlay has hooked those functions, and I can
JS> confirm that no driver or server code calls that. I'd appreciate a
JS> note in the commit message making that more clear.
Will add it.
JS> How did you discover this? Did you actually encounter one of these
JS> crashes, or just notice that the code was unused? You might comment
JS> on that in the commit message too.
I was looking for a dead code, and stumbled upon it.
JS> Then, is xaaOverlay used anywhere, or can it be removed too? If nobody
JS> has seen this crash, maybe nobody cares about this code.
I'd better leave it to someone who knows XAA better than I am.
>> diff --git a/hw/xfree86/loader/sdksyms.sh b/hw/xfree86/loader/sdksyms.sh
>> index 13c5ae5..604762d 100755
>> --- a/hw/xfree86/loader/sdksyms.sh
>> +++ b/hw/xfree86/loader/sdksyms.sh
>> @@ -26,7 +26,6 @@ cat > sdksyms.c << EOF
>> #include "fb.h"
>> #include "fbrop.h"
>> -#include "fboverlay.h"
>> #include "wfbrename.h"
>> #include "fbpict.h"
JS> Isn't this wrong? fboverlay.h still exists and is still included in
JS> some places, including drivers.
Ah, thanks. This header was errorneously removed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 835 bytes
Desc: not available
More information about the xorg-devel