[PATCH] mi: Remove unused overlay support

Jamey Sharp jamey at minilop.net
Fri Jun 11 13:43:36 PDT 2010

On Fri, Jun 11, 2010 at 12:33 PM, Andy Ritger <aritger at nvidia.com> wrote:
> Hi Mikhail,
> The NVIDIA X driver uses the X server's mi overlay support (I believe
> NVIDIA engineers contributed the mi overlay code, originally).  Perhaps
> the FireGL driver uses it, too?  Overlays are still compelling for some
> workstation applications.
> Please do not remove this.

Can you move mioverlay.c into your driver?

Are you actually using XAA with OVERLAY_8_32_PLANAR in your
overlayFlags? If not, you certainly don't need the hooks to mioverlay
from XAA, which means moving mioverlay out of the server is easy.

Otherwise... Well, I don't think you need the
miOverlaySetTransFunction call in XAASetupOverlay8_32Planar, because
you can just pass an equivalent function to miInitOverlay from your
driver. Any thoughts on what to do with XAACopyWindow8_32 and its
doUnderlay flag?

I'm also curious about the bigger questions, because I don't know much
about overlays or workstation use cases. Since you have a great GPU,
why not use it for a composited overlay instead of these 2000 lines of
code? Seems like non-composited overlays should be dead in 2010.


More information about the xorg-devel mailing list