[PATCH] Replace xalloc with malloc

Tomas Carnecky tom at dbservice.com
Wed Jun 16 12:34:28 PDT 2010


On 6/16/10 9:25 PM, Matt Turner wrote:
> On Wed, Jun 16, 2010 at 2:28 PM, Tomas Carnecky<tom at dbservice.com>  wrote:
>> Same for xfree/xrealloc/xcalloc. Also, the return value from
>> malloc/realloc/calloc doesn't require a cast, same for the
>> argument of free(). Also remove if()'s that check if the
>> pointer that is about to be passed to free() is NULL, since
>> free(NULL) is allowed.
>>
>> Signed-off-by: Tomas Carnecky<tom at dbservice.com>
>
> 'Also' in commit messages is usually a sign that the commit needs to
> be split into multiple patches.
>
> Whatever the case,
> Reviewed-by: Matt Turner<mattst88 at gmail.com>

Right. Maybe I shouldn't have written the 'Also'. I don't think the 
cleanup I did around these functions would warrant a separate patch. 
When I was renaming the functions, removing the cast on the same line 
was pretty much a no-brainer for me.

tom



More information about the xorg-devel mailing list