[PATCH] include: Update stale comment after bzero removal
mattst88 at gmail.com
Sun Jun 20 18:58:38 PDT 2010
On Sun, Jun 20, 2010 at 8:39 PM, Matt Turner <mattst88 at gmail.com> wrote:
> On Sun, Jun 20, 2010 at 8:16 PM, Peter Hutterer
> <peter.hutterer at who-t.net> wrote:
>> On Sun, Jun 20, 2010 at 04:37:26AM +0700, Mikhail Gusarov wrote:
>>> Signed-off-by: Mikhail Gusarov <dottedmag at dottedmag.net>
>>> include/misc.h | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>> diff --git a/include/misc.h b/include/misc.h
>>> index 62d813e..38b04b7 100644
>>> --- a/include/misc.h
>>> +++ b/include/misc.h
>>> @@ -108,7 +108,7 @@ typedef struct _CallbackList *CallbackListPtr; /* also in dix.h */
>>> typedef struct _xReq *xReqPtr;
>>> #include "os.h" /* for ALLOCATE_LOCAL and DEALLOCATE_LOCAL */
>>> -#include <X11/Xfuncs.h> /* for bcopy, bzero, and bcmp */
>>> +#include <X11/Xfuncs.h> /* for no apparent reason */
>> couldn't we just remove this include then?
> That'd be ideal, but unfortunately lots of source files use things
> from os.h, but instead of including it, they include misc.h.
> Really, the headers need a massive clean-up.
>>> #define NullBox ((BoxPtr)0)
>>> #define MILLI_PER_MIN (1000 * 60)
Uh, just realized you were talking about X11/Xfuncs.h.
Lots of source files include it to get the prototypes for
memset/memcpy/strcpy it appears.
If it's an appropriate solution, I'll be happy to go through the
xserver and add #include <string.h> to the necessary files so we can
kill off this include.
More information about the xorg-devel