[PATCH] composite: fix freeing of old pixmap until after move/resize/cbw

Keith Packard keithp at keithp.com
Mon Jun 21 16:41:50 PDT 2010

On Mon, 21 Jun 2010 16:33:55 +1000, Dave Airlie <airlied at gmail.com> wrote:

> I'm not sure if
> we are actually better off breaking ABI and adding another callback from the
> ConfigureWindow to composite to make sure the old pixmap is always freed,
> but this should be satisfactory as we should always hit one of the freeing
> paths or else its a bug in the DIX.

This looks right to me -- pulling the piece of the old
MoveWindow/ResizeWindow/ChangeBorderWidth functions into this new
compFreeOldPixmap function. I'd say using these hooks is fine;
ConfigureWindow will always call one of these.

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100621/187d7ece/attachment.pgp>

More information about the xorg-devel mailing list