[PATCH] Use new server API to find the root window.

Jamey Sharp jamey at minilop.net
Tue Jun 22 08:46:01 PDT 2010


Nobody reviewed and the patch to video-dummy works for me, so I pushed it.

I also pushed an equivalent patch to geode, after fixing that driver
for the devPrivates rework. I compile-tested those patches but can't
verify that the whole driver compiles since I'm building on a 64-bit
system.

By the way, Chris, why is the x86 tinderbox processing xcb a second
time at the end?

Jamey

On Fri, Jun 4, 2010 at 4:23 PM, Jamey Sharp <jamey at minilop.net> wrote:
> Signed-off-by: Jamey Sharp <jamey at minilop.net>
> ---
> Um, yeah. I even made a note in the commit message to remind myself to
> find out how to handle ABI changes in the drivers.
>
> Can somebody tell me if this is right, and then I guess I can write the
> corresponding video-geode patch?
>
>  src/dummy_driver.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/src/dummy_driver.c b/src/dummy_driver.c
> index e32c1c7..804e41e 100644
> --- a/src/dummy_driver.c
> +++ b/src/dummy_driver.c
> @@ -779,7 +779,11 @@ DUMMYCreateWindow(WindowPtr pWin)
>        return(ret);
>
>     if(dPtr->prop == FALSE) {
> +#if GET_ABI_MAJOR(ABI_VIDEODRV_VERSION) < 8
>         pWinRoot = WindowTable[DUMMYScrn->pScreen->myNum];
> +#else
> +        pWinRoot = DUMMYScrn->pScreen->root;
> +#endif
>         if (! ValidAtom(VFB_PROP))
>             VFB_PROP = MakeAtom(VFB_PROP_NAME, strlen(VFB_PROP_NAME), 1);
>
> --
> 1.7.0
>
>


More information about the xorg-devel mailing list