[PATCH] Revert "dix: use the event mask of the grab for TryClientEvents."
peter.hutterer at who-t.net
Thu Jun 24 17:51:47 PDT 2010
On Fri, Jun 25, 2010 at 01:27:10AM +0100, Daniel Stone wrote:
> On Fri, Jun 25, 2010 at 10:16:02AM +1000, Peter Hutterer wrote:
> > On Fri, Jun 25, 2010 at 01:09:41AM +0100, Daniel Stone wrote:
> > > The reverted commit was meant to fix some kind of Motif bug (possibly
> > > mouse getting confined to a widget) or something along those lines,
> > > right? The explanation for this commit seems fine to me, but I vaguely
> > > remember the original being some kind of bugfix ... is it no longer
> > > necessary, or just didn't work out, or?
> > I think you're referring to commit 1c612acca8568fcdf9761d23f112adaf4d496f1b
> > dix: if owner-events is true for passive grabs, add the window mask
> > (#25400)
> > that's lesstif bug where the pointer got stuck in a window. With this patch,
> > the need for 1c612 is obsolete, since mask & filter is always true,
> > regardless of owner_events. Or should be, anyway.
> Ah OK, so the original commit was just a general desire to DTRT,
> 1c612acca can now almost certainly be reverted, and that may even fix
it's removed with this patch since this commit didn't revert without
conflicts. but I'll add this to the commit message.
> #25400 if we're being optimistic?
verified as still working with the test case attached to 25400.
More information about the xorg-devel