[PATCH] XWin: Fix for static libXfont use

Jon TURNEY jon.turney at dronecode.org.uk
Mon Jun 28 10:41:10 PDT 2010

On 28/06/2010 16:14, Jon TURNEY wrote:
> On 28/06/2010 15:53, Colin Harrison wrote:
>> Hi,
>> Tiago Vignattiw wrote
>>> all right, I do agree. So if WIN32 macro means Xming only then I'd
>>> give my
>>> review for your patch:

I don't quite understand why you are asking that question.  This problem could 
appear on all platforms which don't satisfy the condition to define 'weak' in 
stubs.h, so I've used the inverse of that condition in my patch, attached.

>> No that covers all Microsoft Windows builds...but lets hear what the
>> Cygwin/X people say.
> That is not correct. WIN32 is not defined under cygwin
> (This is somewhat counter-intuitive since the Win32 API is available,
> but see
> http://cygwin.com/faq/faq-nochunks.html#faq.programming.preprocessor for
> reasoning why)
>> Their tinderbox build is busted (and Xming) without this. See also
>> http://lists.x.org/archives/xorg-devel/2010-June/010538.html
>> So my patch strays a little out of my comfort zone :)
> So that patch as it stands is fine with me :-)
> I can't just change it to check defined(__MINGW__) ||
> defined(__CYGWIN__), as that prevents xfs (and possibly other users of
> libXfont) from building on cygwin. I'll look into this some more and try
> to propose a solution :-)

On reflection, it seems there are no users of libXfont apart from xserver that 
we care about on cygwin, so we might as well fix it like that
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Fix-for-platforms-which-don-t-have-weak-linkage.patch
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100628/c7b4b903/attachment.ksh>

More information about the xorg-devel mailing list