[PATCH] DRI2: make target_sbc signed

Mark Kettenis mark.kettenis at xs4all.nl
Thu Mar 4 09:32:44 PST 2010


> Date: Thu, 4 Mar 2010 09:21:50 -0800
> From: Jesse Barnes <jbarnes at virtuousgeek.org>
> 
> We need to track invalid targets as well as 0 targets, so just make it
> unsigned so our comparisons work like they should.

This not only changes signedness, but also makes it 32-bit, at least
on 32-bit systems.  Was that a conscious decision?

> Reported-by: Kristian Høgsberg <krh at bitplanet.net>
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> 
> diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c
> index 301f4fd..90cca9b 100644
> --- a/hw/xfree86/dri2/dri2.c
> +++ b/hw/xfree86/dri2/dri2.c
> @@ -62,7 +62,7 @@ typedef struct _DRI2Drawable {
>      ClientPtr		 blockedClient;
>      int			 swap_interval;
>      CARD64		 swap_count;
> -    CARD64		 target_sbc; /* -1 means no SBC wait outstanding */
> +    long		 target_sbc; /* -1 means no SBC wait outstanding */
>      CARD64		 last_swap_target; /* most recently queued swap target */
>      int			 swap_limit; /* for N-buffering */
>  } DRI2DrawableRec, *DRI2DrawablePtr;
> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-devel
> 
> 


More information about the xorg-devel mailing list