[PULL] Minor bug-fixes discovered by static analysis.

[Matt Turner]

On Fri, Mar 5, 2010 at 7:12 AM, Oliver McFadden
<oliver.mcfadden at nokia.com> wrote:
> are available in the git repository at:
>
>  git://gitorious.org/omcfadde/xserver.git analysis

Do you not have an account on FreeDesktop.org?

> Oliver McFadden (5):
>      exa: exaFinishAccess: Overrun of static array "pExaScr->access" of size 6 at position 6 with index variable "i"

This looks like it's got a typo in it. 'pPixmap),);' -> notice the extra comma.

>      fb: fbFinishScreenInit: leaked_storage: Variable "(visuals|depths)" goes out of scope

Reviewed-by: Matt Turner <mattst88 at gmail.com>

>      parser: xf86readConfigFile: unreachable: This code cannot be reached: "free(val.str);"

Not sure I understand this one.

>      common: xf86Configure: alloc_strlen: Allocated memory does not have space for the terminating NUL of the string

Reviewed-by: Matt Turner <mattst88 at gmail.com>

>      Xext: IdleTimeBlockHandler: unsigned_compare: Comparing unsigned less than zero is never true. "timeout < 0UL"

I'm not sure this does it exactly. Up at line 2320, we have 'unsigned
long timeout = -1;'.

>
>  Xext/sync.c                       |    4 +---
>  exa/exa.c                         |    4 ++--
>  fb/fbscreen.c                     |    4 ++++
>  hw/xfree86/common/xf86Configure.c |    2 +-
>  hw/xfree86/parser/read.c          |    4 ++--
>  5 files changed, 10 insertions(+), 8 deletions(-)

Matt Turner