[PATCH xf86-video-intel 2/2] Fix handling of target_msc, divisor, remainder in I830DRI2ScheduleSwap()

Mario Kleiner mario.kleiner at tuebingen.mpg.de
Sun Mar 7 16:23:11 PST 2010

On Mar 7, 2010, at 6:18 PM, Jesse Barnes wrote:
> Arg, I did botch that patch.  And of course I only tested the swap
> buffers behavior and not OML's WaitMSC so I didn't catch it.  I'll
> improve the test and push the fix.

No problem. Just fyi: I noticed you added a test in  
I830DRI2ScheduleSwap() that outputs X_Warnings if a swap is scheduled  
more than 100 vblanks ahead. At least for the users of my toolkit,  
scheduling a swap more than 100 vblanks ahead wouldn't be something  
noteworthy but quite a typical case of normal use of the system. At  
the end of a work day some users would probably find ten thousands of  
such warnings in some log, assuming those warnings get logged at the  
normal log level. So this usage case is less weird than one would  
think :-)


More information about the xorg-devel mailing list