[PATCH] dix: Use DeliverGrabbedEvent for implicit passive grabs (#25400)

Peter Hutterer peter.hutterer at who-t.net
Mon Mar 8 15:44:44 PST 2010


On Sat, Mar 06, 2010 at 08:51:25PM +0100, Florian Mickler wrote:
> On Mon, 1 Mar 2010 11:51:31 +1000
> Peter Hutterer <peter.hutterer at who-t.net> wrote:
> 
> > On Wed, Feb 24, 2010 at 08:04:57PM -0800, Keith Packard wrote:
> > > On Thu, 25 Feb 2010 12:49:21 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> > > 
> > > > Bonus point - CheckPassiveGrabsOnWindows suddenly becomes a lot lesss
> > > > complicated.
> > > 
> > > Yeah, and makes it far more obvious that it's following the spec.
> > > 
> > > > Keith, I'll leave that in your court, please apply to master as you see fit,
> > > > I won't include it in my pull requests to avoid duplication.
> > > 
> > > This looks pretty good; I'll review it with the protocol spec, but I'd
> > > like to also know if you happen to have run the test suite over the new
> > > code?
> > 
> > no, not yet. I'm still battling with the test suite on my virtual machines
> > and on an older box.
> > 
> > once I have a suitable installation, I'll likely post the xtest logs but at
> > this point I cannot offer this yet.
> > 
> > Cheers,
> >   Peter
> > _______________________________________________
> > xorg-devel mailing list
> > xorg-devel at lists.x.org
> > http://lists.x.org/mailman/listinfo/xorg-devel
> 
> this regresses my desktop. fluxbox is not able to move the windows
> around anymore. also popup of context-menue does not work. (well
> sometimes it does, but then the fluxbox-keyboard-shortcuts do not work)
> 
> a revert on top of current master fixes it.


thanks. I've reverted it on the nominations branch until we've narrowed down
what the cause of it is.
 
Cheers,
  Peter


More information about the xorg-devel mailing list