Confusing or confused code

[Michael Thayer]

Hello,

I suspect that this code:

http://cgit.freedesktop.org/xorg/xserver/tree/hw/xfree86/common/xf86Mode.c?id=326429badfc76885e4652ddc72860810c0e8d102#n1300

until line 1313 is supposed to be freeing the old list at
scrp->clockRanges, duplicating the user supplied list and storing it
there.  If that is right, then it looks to me though like it will not
work unless scrp->clockRanges is initially NULL and the user only
supplies a list with a single element.  Did I miss something important
there?

Regards,

Michael
-- 
Sun Microsystems GmbH        Michael Thayer
Werkstrasse 24               VirtualBox engineer
71384 Weinstadt, Germany     mailto:michael.thayer at sun.com

Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, 85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels
Vorsitzender des Aufsichtsrates: Martin Haering