[PULL] Cygwin build fixes, XF8Bigfont warnings

Keith Packard keithp at keithp.com
Mon Mar 15 08:35:53 PDT 2010

On Thu, 11 Mar 2010 14:53:21 -0600, "Yaakov (Cygwin/X)" <yselkowitz at users.sourceforge.net> wrote:

> These patches were all previously sent to this list, but some were ignored.
> The following changes since commit f2eacb4646beb25d055de22868f93e6b24f229b6:
>    Peter Hutterer (1):
>          Revert "dix: Use DeliverGrabbedEvent for implicit passive grabs
> (#25400)"
> are available in the git repository at:
>    git://anongit.freedesktop.org/~yselkowitz/xserver.git master
> Yaakov Selkowitz (8):
>        Cygwin/X: Fix make dist after 11252ed82e1f361b99e86521ac9314f868bd1a3a
>        Cygwin/X: Fix windres rule for automake silent rules
>        Use libtool -export-dynamic flag for portability
>        Rename xdmx client to dmxinfo

These all seem fine to me

Reviewed-by: Keith Packard <keithp at keithp.com>

>        Xext: fix prototype warnings in xf86bigfont.c
>        dix: fix XF86Bigfont declaration warnings in dixfonts.c
>        os: fix XF86Bigfont declaration warnings in log.c
>        mi: remove deprecated #include <X11/extensions/xf86bigfstr.h> in miinitext.c

These all put function declarations in .c files instead of headers where
they belong. You can't exactly get function signature typechecking if
the definition and declaration are never compared by the compiler...

Also, please don't mix reviewed and unreviewed patches in a single PULL

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100315/8cf913de/attachment.pgp>

More information about the xorg-devel mailing list