[PATCH 3/5] Fix relink targets for silent rules

Julien Cristau jcristau at debian.org
Wed Mar 17 14:43:21 PDT 2010


On Wed, Mar 17, 2010 at 15:11:08 -0500, Yaakov (Cygwin/X) wrote:

> diff --git a/hw/Makefile.am b/hw/Makefile.am
> index 7409906..92b007a 100644
> --- a/hw/Makefile.am
> +++ b/hw/Makefile.am
> @@ -38,4 +38,4 @@ SUBDIRS =			\
>  DIST_SUBDIRS = dmx xfree86 vfb xnest xwin xquartz kdrive
>  
>  relink:
> -	for i in $(SUBDIRS) ; do $(MAKE) -C $$i relink ; done
> +	$(AM_V_at)for i in $(SUBDIRS) ; do $(MAKE) -C $$i relink ; done

This was there before, but:
AFAICT, this rule will succeed even if one of the subdir relink targets
fails, because the shell will keep going to the next iteration of the
loop.

        set -e; for i in $(SUBDIRS); do ...; done

seems to do the trick, and properly fails as soon as one of the subdir
commands fails.

Cheers,
Julien


More information about the xorg-devel mailing list