[PATCH libX11] No need for req->firstKeyCode to be set twice.

Fernando Carrijo fcarrijo at yahoo.com.br
Wed Mar 17 19:53:16 PDT 2010


There is no reason to set req->firstKeyCode twice when a client, wishful
for changing keyboard mappings, calls XChangeKeyboardMapping. This patch
fixes the mistake by making no functional changes to libX11 whatsoever.

Signed-off-by: Fernando Carrijo <fcarrijo at yahoo.com.br>
---
 src/SetPntMap.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/SetPntMap.c b/src/SetPntMap.c
index eaa642d..94ed0c3 100644
--- a/src/SetPntMap.c
+++ b/src/SetPntMap.c
@@ -69,7 +69,6 @@ XChangeKeyboardMapping (
     req->firstKeyCode = first_keycode;
     req->keyCodes = nkeycodes;
     req->keySymsPerKeyCode = keysyms_per_keycode;
-    req->firstKeyCode = first_keycode;
     req->length += nkeycodes * keysyms_per_keycode;
     nbytes = keysyms_per_keycode * nkeycodes * 4;
     Data32 (dpy, (long *)keysyms, nbytes);
-- 
1.6.3.3




More information about the xorg-devel mailing list