[PATCH app, driver, libs 0/43] Replace deprecated Automake INCLUDES variable

Gaetan Nadon gaetan.nadon at videotron.ca
Fri Mar 19 19:26:09 PDT 2010

On Fri, 2010-03-19 at 13:53 -0700, Alan Coopersmith wrote:

> Gaetan Nadon wrote:
> > The server sticks -fvisibility compiler flag in the pkg Cflags which
> > does not help while 99% of pkg-config files on my distro are compiler
> > flags free.
> Which is probably a bug in itself - I end up removing @symbol_visibility@
> from xorg-server.pc.in when building our packages, since we support both
> gcc & Sun Studio, and they take different flags for that option.

I tend to agree, providing compiler flags such as this one is pushing
the "convenience" envelop. This flag should be specified in the driver
module, but it is significant work. There is no facility to specify a
portable compiler flag. In this particular case, it could be supplied
through a server macro and included in each driver makefile. 

If we are willing to make the assumption that no other modules will pass
a compiler flag in pkgconfig, then we can have pre-processor/compiler
flags separation in apps and libs. 

As a side note, it looks like the server config handles the SUN

		AC_CHECK_DECL([__SUNPRO_C], [SUNCC="yes"], [SUNCC="no"])
		if test x$SUNCC = xyes; then

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100319/8ac31310/attachment.html>

More information about the xorg-devel mailing list