[PATCH] xfree86: remove if 1 from the dawn of time.

Corbin Simpson mostawesomedude at gmail.com
Mon Mar 22 18:33:28 PDT 2010


On Mon, Mar 22, 2010 at 5:36 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> 7+ years for an if 1 should be enough to just admit that there's no other
> option.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  hw/xfree86/os-support/shared/posix_tty.c |   10 ----------
>  1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/hw/xfree86/os-support/shared/posix_tty.c b/hw/xfree86/os-support/shared/posix_tty.c
> index bf1bb03..4ba8599 100644
> --- a/hw/xfree86/os-support/shared/posix_tty.c
> +++ b/hw/xfree86/os-support/shared/posix_tty.c
> @@ -137,19 +137,9 @@ xf86OpenSerial (pointer options)
>
>        if (!isatty (fd))
>        {
> -#if 1
>                /* Allow non-tty devices to be opened. */
>                xfree(dev);
>                return (fd);
> -#else
> -               xf86Msg (X_WARNING,
> -                        "xf86OpenSerial: Specified device %s is not a tty\n",
> -                        dev);
> -               SYSCALL (close (fd));
> -               errno = EINVAL;
> -               xfree(dev);
> -               return (-1);
> -#endif
>        }
>
>        /* set up default port parameters */
> --
> 1.6.6.1

*starts slow clap*

Reviewed-by: Corbin Simpson <MostAwesomeDude at gmail.com>

-- 
When the facts change, I change my mind. What do you do, sir? ~ Keynes

Corbin Simpson
<MostAwesomeDude at gmail.com>


More information about the xorg-devel mailing list