[PATCH] Use SED set by libtool macros

Gaetan Nadon memsize at videotron.ca
Wed Mar 24 06:23:30 PDT 2010

On Wed, 2010-03-24 at 08:53 +0100, Rémi Cardona wrote:

> Le 24/03/2010 07:21, Yaakov (Cygwin/X) a écrit :
> > From: Yaakov Selkowitz <yselkowitz at users.sourceforge.net>
> > 
> > We now use libtool, which calls AC_PROG_SED and sets SED as the path to
> > a fully-functional 'sed' (which may also be called 'gsed' if GNU sed is
> > installed alongside a proprietary version).  Therefore we should respect
> > this value of SED so we are sure to use the correct one.
> Then configure should still call AC_PROG_SED explicitely. Relying on
> libtool's macros for that _will_ bite us at some point.
> The rest of the patch is fine.

I agree AC_PROG_SED and similar macros should be explicitly called. This
alerts the
reader that the program in question is used, so it also has a
documentation benefit.
It's of a great help to find where env variables are defined.

> Cheers,
> Rémi
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100324/67f2ad35/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100324/67f2ad35/attachment.pgp>

More information about the xorg-devel mailing list