[PATCH 3/5] Replace some input devPrivates with regular struct fields

Simon Thum simon.thum at gmx.de
Sun May 2 08:48:50 PDT 2010


Am 02.05.2010 13:11, schrieb Simon Thum:
> If your aim is getting rid of DevPrivate keys, I can probably live with
> it. But conceptually, the DeviceVelocityPtr is independent of input
> device properties and I'd like to keep it that way. The reason is that
> in principle, there may be more than one acceleration context
> (DeviceVelocityRec) per device. ATM we don't use it, but since work is
> being underway to revamp the scroll wheel, this may become more useful,
> so I'm not inclined to blur concepts (so far).
> 
> So IMO, a dev private is exactly what it takes. The props are tied to
> the predictable _scheme_, which is indeed per-device. I'm happy to
> provide a checked allocation patch, though.
Dammit, too late...

Would you agree to revert the ptrveloc.* part of the patch? I'd rather
fix this when fixing the accel setup. The scheme stuff isn't fully
worked out, but the props really belong there.

Cheers,

Simon


More information about the xorg-devel mailing list