[PATCH 05/10] xfree86: bus: enable sparc code usage as its definition
Tiago Vignatti
vignatti at freedesktop.org
Sun May 2 14:48:05 PDT 2010
Hi,
Mark Kettenis wrote:
>> From: Tiago Vignatti <tiago.vignatti at nokia.com>
>> Date: Sun, 2 May 2010 23:07:41 +0300
>>
>> This is here since the initial revision but it's not synchronized with the
>> definitions in both xf86.h and xf86sbusBus.h
>
> Huh? The extra declarations in xf86.h and xf86sbusBus.h are harmless,
> so your conclusion that these !defined(__OpenBSD__) clauses can go is
> flawed. If you really insist on synchronizing things, please adjust
> the headers.
Yeah, headers and code aren't synchronized. Just it. But it's fine to me
to work on the headers then. I'll provide another patch.
> The reason for this !defined(__OpenBSD__) is that the code in
> xserver/hw/xfree86/common/xf86sbusBus.c is too OS-specific to be
> usable on OpenBSD. I have a (much simpler) OpenBSD-specific
> replacement for that code. I should probably talk to Matthieu to see
> how we can integrate that code nack upstream. Until that's take care
> of those !defined(__OpenBSD__) makes sure that official Xorg releases
> stand a chance to compile on OpenBSD/sparc and OpenBSD/sparc64. You
> won't be able to use the accelerated drivers for SBus and UPA grphics
> hardware, but PCI hardware and the unuaccelerated wsfb framebuffer
> driver should work fine.
I don't have such hardware. But we all would be really happy if you
could test it though.
Thanks,
Tiago
More information about the xorg-devel
mailing list