[PATCH 00/10] Clean up and reorganize BUS configuration code

Aaron Plattner aplattner at nvidia.com
Mon May 3 17:50:53 PDT 2010


On Sun, May 02, 2010 at 01:07:36PM -0700, Tiago Vignatti wrote:
> Hi,
> 
> Following there are a couple of trivial fixes, mostly related with bus
> configuration in Xorg. Besides a lot of clean up in the code, the most
> apparently benefit is that xf86Init is now decoupled from PCI code.
> 
> The API is being changed in xf86.h (hi Aaron) by removing xf86EnableAccess.

Thanks for the heads up.  The NVIDIA driver doesn't use any of this stuff.

> For the open-source ones I can see only four (old - no up to date) drivers
> using it. For these, I think we can go and simply wrap with #ifndef
> XSERVER_LIBPCIACCESS the xf86EnableAccess function (this macro initially was
> used when libpciaccess entered on scene but seems that lost its original
> purpose on the middle of its life). Opinions? 
> 
> Please, review the patches. The work lives here also:
> 
>     git://anongit.freedesktop.org/~vignatti/xserver [bus-cleanup]
> 
> 
> Thanks,
> 
>                  Tiago
> 
> 
> Tiago Vignatti (10):
>   xfree86: remove unused xf86AccessInit()
>   xfree86: bus: fix Enter/Leave accesses behaviour
>   xfree86: bus: reuse already assigned variable when fb driver claimed
>   xfree86: bus: rework xf86PostProbe logic and remove useless log info
>   xfree86: bus: enable sparc code usage as its definition
>   xfree86: bus: simplify entity related hooks
>   xfree86: bus: fb drivers might want to use vga arbitration either
>   xfree86: bus: remove SetSIGIOForState and simplify the code
>   xfree86: remove xf86EnableAccess
>   xfree86: remove PCI dependency from InitOutput
> 
>  hw/xfree86/common/xf86.h          |    1 -
>  hw/xfree86/common/xf86Bus.c       |  289 +++++++++++++++++++----------------
>  hw/xfree86/common/xf86Configure.c |    2 -
>  hw/xfree86/common/xf86Init.c      |  313 +------------------------------------
>  hw/xfree86/common/xf86Priv.h      |    3 +-
>  hw/xfree86/common/xf86pciBus.c    |  160 +++++++++++++++++++
>  hw/xfree86/common/xf86pciBus.h    |    3 +
>  7 files changed, 327 insertions(+), 444 deletions(-)


More information about the xorg-devel mailing list