[PATCH 03/14] miwideline: Factor out span buffer allocation.

[Adam Jackson]

On Wed, 2010-05-12 at 12:16 -0700, Jamey Sharp wrote:
> On Mon, May 10, 2010 at 8:13 AM, Adam Jackson <ajax at nwnk.net> wrote:
> > On Sat, 2010-05-08 at 16:39 -0700, Jamey Sharp wrote:
> >> Signed-off-by: Jamey Sharp <jamey at minilop.net>
> >
> > I suspect that, at one point in time, this may have been manually
> > inlined for performance.  Not that I care, just that it's likely.  Might
> > be good to compare runs of x11perf -wline{10,100,500}.
> 
> Any differences with and without this patch are lost in the level of
> noise I'm getting in my x11perf runs. It looks like the patch is
> somewhere between 2% slower and 2% faster on those three tests. Is
> that even useful to note in the commit message? I tested before and
> after the patch, and also with the InitSpans function declared inline,
> and all three versions have nearly identical performance. On modern
> CPUs they certainly ought to be about the same, or a little faster
> overall due to better code density in cache.

That's rigorous enough for me.  Thanks for checking!

Reviewed-by: Adam Jackson <ajax at redhat.com>

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100513/6cf66c9f/attachment.pgp>