[PATCH] Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop index.

[Jeremy Huddleston]

Gah!  I'm an idiot.  I can't believe I spent over an hour debugging something because of confusing --i and i-- when editing gc.c

When I merge your branch rather than relying on my lack of ability to edit a one line change in a file, it works correctly

Tested-by: Jeremy Huddleston <jeremyhu at apple.com>

Do you have the malloc -> calloc change ready as well?

On May 14, 2010, at 11:30, Jamey Sharp wrote:

> On Fri, May 14, 2010 at 11:27 AM, Jeremy Huddleston <jeremyhu at apple.com> wrote:
>> On May 14, 2010, at 11:19, Jamey Sharp wrote:
>>> I'd expect to see this result with yesterday's master. Are you sure
>>> you're testing with my patch? :-)
>> 
>> Yep:
>> 
>> 443         for (i = Ones(mask); --i; )
> 
> That's... not *my* patch. That's a patch that resembles my patch quite
> strongly but does not fix anything. My patch says i--. I've
> triple-checked now.
> 
> Jamey