[PATCH] Device init: Don't crash when CreateGC fails.

Keith Packard keithp at keithp.com
Fri May 14 14:13:09 PDT 2010


On Fri, 14 May 2010 12:47:06 -0700, Jamey Sharp <jamey at minilop.net> wrote:
> On Fri, May 14, 2010 at 12:40 PM, Jeremy Huddleston <jeremyhu at apple.com> wrote:
> > Thanks Jamey!
> >
> > Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
> 
> No problem! Out of curiousity, did you just review the patch, or also
> test it? I'd be inclined to add a tested-by line as well for you if
> you did, in fact, test. :-)
> 
> Also I'm really hoping Peter or somebody else who knows the input bits
> will review this before it's merged. I'm confident it fixes the
> symptom, and I'm pretty sure the patch isn't outright wrong, but there
> might be something better to do?

Let me know when you're ready to have this merged then, if Peter has
comments it would be good to see them first.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100514/0c2e8d30/attachment.pgp>


More information about the xorg-devel mailing list